Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add file extension to import path to support Node16 and NodeNext module resolution #170

Closed
wants to merge 1 commit into from

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Jul 29, 2023

Description

When using node16 or nodenext moduleresolution, tsc would throw errors. See #169

References

relative import paths need full extensions (e.g we have to write import "./foo.js" instead of import "./foo")

typescriptlang.org/docs/handbook/esm-node.html

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@frederikprijck frederikprijck requested a review from a team as a code owner July 29, 2023 13:39
@frederikprijck frederikprijck changed the title fix: add file extension to import path to support Node16 module resol… fix: add file extension to import path to support Node16 module resolution Jul 29, 2023
@frederikprijck frederikprijck changed the title fix: add file extension to import path to support Node16 module resolution fix: add file extension to import path to support Node16 and NodeNext module resolution Jul 29, 2023
@frederikprijck frederikprijck marked this pull request as draft July 29, 2023 13:50
@frederikprijck frederikprijck marked this pull request as ready for review July 29, 2023 13:56
@frederikprijck
Copy link
Member Author

Marking as draft until we got some feedback on #169

@frederikprijck frederikprijck marked this pull request as draft July 29, 2023 14:03
@jonkoops
Copy link
Contributor

jonkoops commented Aug 3, 2023

@frederikprijck I think we can close this one now that all the files that end up in the distribution are bundled (also the types). It would however be nice if we can default to Node16 for the TSConfig at some point, but I have already found several dependencies that have broken types under that mode, so I'll have to fix those upstream first.

@jonkoops
Copy link
Contributor

@frederikprijck I think the branch for this PR can be deleted as well.

@frederikprijck frederikprijck deleted the fix/node-16-module-resolution branch August 13, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants