Shallow embedding of ArrayPut and ArrayTake #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many of the missing things are on my wip-reftypes branch. Since on master there's no typechecking for array operations, many things were left out as they weren't needed or didn't make sense. |
array_map2 : "('a ⇒ 'b ⇒ 'a × 'b) ⇒ 'a list ⇒ 'b list ⇒ ('a list × 'b list)" is defined in isabelle. But cogent pairs are compiled to some record, thus necessating to insert coercions before and after calling this map2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the shallow embedding of ArrayPut, which is enough to compile the shallow embedding the led driver..
This PR also implements the shallow embedding of ArrayTake, but it couldn't be tested, as it seems the compilation of ArrayTake is not yet implemented (yielding TODO fvIP: PArrayTake unimplemented)