Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test place_connection() more #209

Merged
merged 48 commits into from
Mar 18, 2024
Merged

Test place_connection() more #209

merged 48 commits into from
Mar 18, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Jan 25, 2024

Resolves #102. Changes:

  • Use a single TEManager instance throughout the app, thus avoiding TopologyManager invocations. The latter probably should be a hidden implementation detail of PCE; we should tackle that separately.
  • Test place_connection() under various conditions.
  • Remove some unused methods from connection controller.

Getting this merged is a pre-condition for getting to #225 (handling connection deletions). This is probably incomplete and there are likely to be issues, but we can test address them later once things are in place.

@sajith sajith self-assigned this Jan 25, 2024
@coveralls
Copy link

coveralls commented Jan 25, 2024

Pull Request Test Coverage Report for Build 8299597160

Details

  • 23 of 32 (71.88%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+12.1%) to 50.772%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/messaging/rpc_queue_consumer.py 4 5 80.0%
sdx_controller/controllers/topology_controller.py 1 3 33.33%
sdx_controller/handlers/connection_handler.py 9 12 75.0%
sdx_controller/handlers/lc_message_handler.py 2 5 40.0%
Totals Coverage Status
Change from base Build 8287985217: 12.1%
Covered Lines: 699
Relevant Lines: 1409

💛 - Coveralls

This does not work as it should yet because place_connection() sets up
its own TEManager instance with topologies populated from the DB.
This was removed on merging because swagger_server/test/__init__.py
was gone.
@sajith sajith marked this pull request as ready for review March 15, 2024 17:06
@sajith sajith merged commit ca5d85a into main Mar 18, 2024
11 checks passed
@sajith sajith deleted the 102.place-connection-tests branch March 18, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Test place connection API exhaustively
3 participants