Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor on docker-compose and env file #109

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

italovalcy
Copy link
Contributor

Related to Issue #106

Description of the change

  • Removing unnecessary variables from docker compose
  • aggregating variables for RabbitMQ Host
  • Using new endpoints for OXP provisioning URL (kytos so far)
  • removing sdx-test container

@italovalcy italovalcy marked this pull request as ready for review April 18, 2024 20:13
Copy link
Collaborator

@lmarinve lmarinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centralizing all environment variable values into a single .env file. This approach can enhance the simplicity, security, maintainability, and scalability of the application’s configuration management. By adopting this practice, we can make it easier for new developers to onboard, improve security measures, and ensure quick updates without inconsistencies. By maintaining a single source of truth for environment settings, we can ensure that the project remains efficient and aligned with industry standards as it evolves.

@italovalcy
Copy link
Contributor Author

centralizing all environment variable values into a single .env file. This approach can enhance the simplicity, security, maintainability, and scalability of the application’s configuration management. By adopting this practice, we can make it easier for new developers to onboard, improve security measures, and ensure quick updates without inconsistencies. By maintaining a single source of truth for environment settings, we can ensure that the project remains efficient and aligned with industry standards as it evolves.

Hi @lmarinve thanks for the comment and suggestion. I've pushed commit 5aabbc6 to move all variable definitions to the env file. Please let me know if you have additional comments.

Copy link
Collaborator

@lmarinve lmarinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants