feat!: update to parser API v3 #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaslagoni
requested review from
fmvilas,
derberg,
magicmatatjahu and
asyncapi-bot-eve
as code owners
jonaslagoni
changed the title
jonaslagoni
commented
Nov 16, 2023
helpers/all.js
Outdated
| @@ -133,7 +133,9 @@ export function includeFile(pathFile) { | |||
| * and annotates that specification is parsed. | |||
| */ | |||
| export function stringifySpec(asyncapi) { | |||
| return stringify(asyncapi); | |||
| const stringifiedDoc = stringify(asyncapi); | |||
| if(stringifiedDoc === undefined) throw new Error("Unable to stringify parsed AsyncAPI document given by the generator, this should never happen... Please raise an issue for the html-template.") | |||
There was a problem hiding this comment.
This is a big cause of problems i.e. #456 (have had it multiple times). So thought it was better to throw an error instead of generating empty HTML pages.
jonaslagoni
commented
Nov 16, 2023
| tags: | ||
| - name: costing | ||
| description: "Costing channels, used by Costing clients." | ||
| title: Streetlights API |
There was a problem hiding this comment.
Changed the test document to the v2 document only converted to v3 to keep it consistent.
jonaslagoni
commented
Nov 16, 2023
derberg
reviewed
Nov 21, 2023
derberg
previously approved these changes
Nov 21, 2023
fmvilas
previously approved these changes
Nov 21, 2023
jonaslagoni
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
fmvilas
approved these changes
Nov 29, 2023
|
/rtm |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes that parser versions started to drift, as of
3.0.0-next-major-spec.9we start using parser API v3 and no longer v2. This PR updates the template to use the newest parser API v3.Related to #456
Supersedes #461