env: fix environment variable parsing #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment variables are fairly free-form; all characters are allowed except for '\0', so FOO-BAR=baz should work. This leaves callers in a bit of a conundrum if they don't know (and don't particularly trust) program names in advance. To make things safer, and more explicit, a second -- can now be added to the environment variable list.
mstory21
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variables are fairly free-form; all characters are allowed except for '\0', so FOO-BAR=baz should work.
This leaves callers in a bit of a conundrum if they don't know (and don't particularly trust) program names in advance. To make things safer, and more explicit, a second -- can now be added to the environment variable list.