Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added unit tests and fix e2e tests for application sync decoupling feature #19966

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

anandf
Copy link
Contributor

@anandf anandf commented Sep 17, 2024

Improvements done to the Application sync decoupling feature done as part of PR #17403

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@anandf anandf requested review from a team as code owners September 17, 2024 12:55
Copy link

bunnyshell bot commented Sep 17, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-kfaiun.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-kfaiun.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Sep 17, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@anandf anandf changed the title Improvements sync with impersonate chore: Add unit tests and fix e2e tests for application sync decoupling feature Sep 17, 2024
@anandf anandf changed the title chore: Add unit tests and fix e2e tests for application sync decoupling feature chore: Added unit tests and fix e2e tests for application sync decoupling feature Sep 17, 2024
@anandf anandf marked this pull request as draft September 17, 2024 12:56
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.87%. Comparing base (b824956) to head (3b0a3b7).

Files with missing lines Patch % Lines
controller/sync.go 70.00% 2 Missing and 1 partial ⚠️
util/settings/settings.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19966      +/-   ##
==========================================
+ Coverage   55.85%   55.87%   +0.02%     
==========================================
  Files         321      321              
  Lines       44490    44496       +6     
==========================================
+ Hits        24849    24863      +14     
+ Misses      17077    17069       -8     
  Partials     2564     2564              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anandf anandf force-pushed the improvements_sync_with_impersonate branch from 4f1037c to c675f11 Compare September 23, 2024 10:54
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: anandf <anjoseph@redhat.com>
@anandf anandf force-pushed the improvements_sync_with_impersonate branch from 3103229 to c144df8 Compare September 24, 2024 17:42
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: anandf <anjoseph@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant