Refactor field migration into a more generalized migrator + add metho… #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d inheritance migrator
Juuxel
approved these changes
May 2, 2024
.../java/net/fabricmc/loom/configuration/providers/forge/MethodInheritanceMappingsMigrator.java
Outdated
Show resolved
Hide resolved
|
Just tested this in my project. Worked without any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d inheritance migrator
Closes #206
This PR offers a different solution to the conflicting mappings issue, instead of changing the namespaces that Loom remaps from, this PR fixes the mapping by dropping conflicting names.
As with the field migrator fix, the fix does not radioactively change the remapped jar, but requires a complete refresh by the user, but this should be fine considering that there should be no current setups with the corresponding NeoForge versions.
The reason for this method instead is how much Loom relies on the intermediary namespace, and that it might cause issues that are tricky to debug or fix.
The PR currently 1. refactors field migrator that it becomes one of the migrators, 2. add a new method inheritance migrator
While this PR is significantly larger in diff, it is mostly in archloom-specific classes