NeoForge support

[Juuxel]

Fixes #146. Fixes #167.

TODO

• Check/update runtime component for NeoForge support (Modularise, add NeoForge support and port to mapping-io architectury-loom-runtime#3)
• Finish field migrating mapping provider
• Adapt Forge DependencyProviders
• Adapt anything using the net.minecraftforge package directly
• Do we need (or can we) to replace hardcoded net.minecraftforge tools with tools read from the config jsons?
  • I don't think so
• Remap mixins from dependencies
• Rename forgeRuntimeLibrary to bootstrapRuntimeLibrary or similar, it's the bootstrap launcher's "legacy classpath" contents
  • not critical, postponed
• Add tests for NeoForge
• Fix binpatching
• Fix bootstrap not included in shadow jar (should I just drop DFU...?)
• Fix ForgeLoggerConfig not reading Neo's logger config (presumably still in FML)
• Fix/investigate Loom's colourful logger config automatically being replaced with Neo's config
  • Note: these are irrelevant as FML forces its config to be always in use
• Prevent the use of the deprecated datagen api on Neo
• Fix coremod member remapping at runtime
• Add fix for Changing the patch version in MinecraftPatchedProvider doesn't invalidate further jars #167 so that old jars will be regenerated when the patch changes
  • This is needed because the missing coremod remapping was readded
• Split the extension for Forge/NeoForge
  • Neo should not have mixins (see below), forge logger config (see above), AW conversion
• Split ModsToml parsing between Forge/NeoForge, support mixins array
  • Not needed
• Update Neo version in test, re-enable joined neoform/mcp route
• Fix tests
• Disable naming service on Neo
• Make casing consistent in APIs (NeoForge/neoForge vs Neoforge/neoforge)

[github-actions]

Test Results

  97 files  +  3    97 suites  +3   2h 57m 32s ⏱️ - 47m 23s
606 tests +12  605 ✔️ +23  0 💤  - 1  1 ❌  - 10 
609 runs   - 19  608 ✔️ +25  0 💤  - 1  1 ❌  - 43 

For more details on these failures, see this check.

Results for commit c234ea4. ± Comparison against base commit e3b51e9.

This pull request removes 20 and adds 21 tests. Note that renamed tests count towards both.

 '
Fabric-Loom-Remap: broken
Fabric-Loom-Remap: false
Fabric-Loom-Remap: true
Something: Hello
], #1]
], #2]
], #3]
], #4]
…

net.fabricmc.loom.test.integration.DebugLineNumbersTest ‑ Debug test
net.fabricmc.loom.test.integration.neoforge.SimpleNeoForgeTest ‑ build 1.20.2 20.2.51-beta "net.fabricmc:yarn:1.20.2+build.4:v2"
net.fabricmc.loom.test.integration.neoforge.SimpleNeoForgeTest ‑ build 1.20.2 20.2.51-beta loom.officialMojangMappings()
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [fabric.mod.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: false

], #2]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: broken

], #6]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: false

], #4]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Something: Hello

], #7]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: true, entries: [fabric.mod.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: true

], #3]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: true, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: true

], #5]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ remap requirements [requirements: OPT_IN, entries: [META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: true

], #2]
…

♻️ This comment has been updated with latest results.

[shedaniel]

LGTM!