Skip to content

Commit

Permalink
chore: update uuid from v8 to v9
Browse files Browse the repository at this point in the history
this will help to address an issue with jest >28 by default expects cjs exports in browser env
https://jest-archive-august-2023.netlify.app/docs/28.x/upgrading-to-jest28/#packagejson-exports
https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md#900-2022-09-05
see: "add Jest/jsdom compatibility" in changelog

- this commit also removes test/jest resolver.js file which only existed to resolve the jest cjs browser issue
  • Loading branch information
mdalpozzo authored and Brian-Holland committed Aug 20, 2024
1 parent 45c7e2d commit 6790e2f
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 46 deletions.
1 change: 0 additions & 1 deletion jest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ const config: Config.InitialOptions = {
setupFilesAfterEnv: ['<rootDir>src/tooling/helpers.ts'],
testEnvironment: 'jsdom',
coveragePathIgnorePatterns: ['tooling'],
resolver: `<rootDir>/src/tests/common/resolver.js`,
};

export default config;
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"tributejs": "^5.1.3",
"use-deep-compare-effect": "^1.8.1",
"use-local-storage-state": "^4.0.0",
"uuid": "^8.3.1"
"uuid": "^9.0.1"
},
"devDependencies": {
"@appfolio/eslint-config-appfolio-react": "^2.0.2",
Expand Down
33 changes: 0 additions & 33 deletions src/tests/common/resolver.js

This file was deleted.

13 changes: 2 additions & 11 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ __metadata:
uncontrollable: ^4.1.0
use-deep-compare-effect: ^1.8.1
use-local-storage-state: ^4.0.0
uuid: ^8.3.1
uuid: ^9.0.1
peerDependencies:
react: ">= 16.8"
react-dom: ">= 16.8"
Expand Down Expand Up @@ -16343,16 +16343,7 @@ __metadata:
languageName: node
linkType: hard

"uuid@npm:^8.3.1":
version: 8.3.2
resolution: "uuid@npm:8.3.2"
bin:
uuid: dist/bin/uuid
checksum: 5575a8a75c13120e2f10e6ddc801b2c7ed7d8f3c8ac22c7ed0c7b2ba6383ec0abda88c905085d630e251719e0777045ae3236f04c812184b7c765f63a70e58df
languageName: node
linkType: hard

"uuid@npm:^9.0.0":
"uuid@npm:^9.0.0, uuid@npm:^9.0.1":
version: 9.0.1
resolution: "uuid@npm:9.0.1"
bin:
Expand Down

0 comments on commit 6790e2f

Please sign in to comment.