Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archived builder choices returns boolean instead of strings #4226

Closed
wants to merge 2 commits into from

Conversation

ValJed
Copy link
Contributor

@ValJed ValJed commented Jul 20, 2023

Summary

Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Open a piece manager modal and select several pieces
  3. Click the "Archive" button on the top left of the manager and confirm that it should proceed
  4. Check that all pieces have been archived properly

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ValJed ValJed requested a review from boutell July 20, 2023 15:52
@@ -260,7 +260,7 @@ export default {
busy: true,
qs: {
all: '1',
archived: this.relationshipField || this.pageSetMenuSelectionIsLive ? '0' : 'any',
archived: this.relationshipField || this.pageSetMenuSelectionIsLive ? false : 'any',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s a query string, booleans aren’t a thing in query string parameter values.

That’s why the string representation is used in this particular case.

I recommend you solve this problem on the other end, by convincing batch operation if to accept strings 0 and 1 as false and true.

@ValJed ValJed closed this Nov 6, 2023
@ValJed ValJed deleted the fix-archived-builder-choices branch April 16, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants