Areas / Rich Text Widget UI updates #4204
Conversation
| @@ -61,7 +61,6 @@ export default { | |||
| buttonOptions() { | |||
| return { | |||
| label: 'apostrophe:addContent', | |||
| iconOnly: this.empty === false, | |||
There was a problem hiding this comment.
lets us reveal the label on hover
| @@ -587,32 +593,92 @@ export default { | |||
| } | |||
| } | |||
|
|
|||
| // TODO commented code awaiting the triumphant return of the canvas -SR | |||
| :tooltip="{ | ||
| content: tool.label, | ||
| placement: 'top', | ||
| delay: 650 |
There was a problem hiding this comment.
big delay on these because they should be obvious, but still present if they need them.
| .apos-tooltip__wrapper { | ||
| transition: all 0.2s var(--a-transition-timing-bounce); | ||
| /* stylelint-disable-next-line time-min-milliseconds */ | ||
| transition-delay: 0.1s; |
There was a problem hiding this comment.
ensure we are visible
|
Running the while cypress tests with the |
|
A very small issue, the widget breadcrumb UI gets behind the widget modal header: 
|
modules/@apostrophecms/area/ui/apos/components/AposAreaWidget.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: ETLaurent <ETLaurent@users.noreply.github.com>
There was a problem hiding this comment.
Looking good on testbed! Did a little monkey testing but I might have missed few issues here and there.
Someone with a better expertise on CSS could review it as well.
Overall looks good to me, provided that the cypress tests pass and the comment about ?. is resolved.
Approving it in order not to block it since I'll be away for a time!
Nice enhancements 👏
|
One test is failing, to check if it's related to the changes made in the PR: 
https://github.com/apostrophecms/testbed/actions/runs/5271518855
|
|
added a |
Summary
Note: No changes to interaction patterns, so things don't behave differently they are just enhanced. The only thing we we add is tooltips in more places.
What are the specific steps to test this change?
What kind of change does this PR introduce?
(Check at least one)