fix: Updates Swift Package.resolved file version format
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
calvincestari
commented
Mar 19, 2024
| } | ||
|
|
||
| func test__matchCLIVersionToApolloVersion__givenPackageResolvedFileInXcodeWorkspaceAndProject_withVersion2FileFormat_hasMatchingVersion_returns_versionMatch_fromWorkspace() throws { | ||
| func test__matchCLIVersionToApolloVersion__givenPackageResolvedFileInXcodeWorkspaceAndProject_withKnownResolvedFileFormats_hasMatchingVersion_returns_versionMatch_fromWorkspace() throws { |
There was a problem hiding this comment.
This test was changed to have both the workspace and project use the same Apollo version. Previously they were different and that could also affect the outcome. So this test was changed and there is a new test below that has mismatched versions to ensure that the workspace one is still selected.
BobaFetters
pushed a commit
that referenced
this pull request
Mar 20, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Mar 20, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Mar 20, 2024
117e41c3 fix: Updates Swift file version format (#304) git-subtree-dir: apollo-ios-codegen git-subtree-split: 117e41c33393b6abae6842f8a0fbe498611668ca
BobaFetters
pushed a commit
that referenced
this pull request
Mar 20, 2024
… format git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 1ff20e5 git-subtree-split: 117e41c33393b6abae6842f8a0fbe498611668ca
jamesonwilliams
pushed a commit
to jamesonwilliams/apollo-ios-dev
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3355.
This is the fix to accept version
3as a valid format for the version checker.