Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes boundary from accept header #234

Conversation

calvincestari
Copy link
Member

This is the same as #232 but limited to non-subscription operations and to be merged into the feature/defer-execution-networking branch to only be applicable once all the defer work is merged into main.

The boundary portion of the accept header has no effect on the boundary in the received multipart response so we can remove it and send less data in the request. The multipart response handler is already built to handle any value sent back as the boundary and use that to parse the chunks.

More details in apollographql/router#4395 and apollographql/router#4447.

@calvincestari calvincestari requested a review from a team as a code owner January 10, 2024 18:15
@calvincestari
Copy link
Member Author

I'm going to go ahead and merge this with the test failure because the test failure is caused by a warning in the test codegen configuration job. The warning is about unused property assignments that will be handled in PR #217 as part of review feedback.

/Users/runner/work/apollo-ios-dev/apollo-ios-dev/apollo-ios/Sources/Apollo/MultipartResponseDeferParser.swift:67:16: error: value 'hasNext' was defined but never used; consider replacing with boolean test
if let hasNext = object.hasNext {
~~~~^~~~~~~~~~
!= nil
/Users/runner/work/apollo-ios-dev/apollo-ios-dev/apollo-ios/Sources/Apollo/MultipartResponseDeferParser.swift:71:16: error: value 'incremental' was defined but never used; consider replacing with boolean test
if let incremental = object.incremental {
~~~~^~~~~~~~~~~~~~
!= nil

@calvincestari calvincestari merged commit 4555e08 into feature/defer-execution-networking Jan 10, 2024
14 of 15 checks passed
@calvincestari calvincestari deleted the defer/remove-boundary-from-multipart-header branch January 10, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants