fix: support ip:port in host #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sn0rt
approved these changes
Dec 6, 2023
|
I will check this later, thanks for your contribution! |
|
@theweakgod are you stilling working on the pr? |
Sure |
|
@theweakgod please resolve the review comments |
@monkeyDluffy6017 What should I do, I have replied |
Ok, I got it |
|
@theweakgod I didn't see your reply |
But I really replied.
|
|
The comment is still pending, please check the button at the upright corner |
Okay, thank you, this is my first time using this. |
monkeyDluffy6017
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support ip:port in host
#138
#10531