[type:feat]Add dynamically scale admin module #5602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terminator111
changed the title
|
not delete icon |
done. |
misaya295
reviewed
Aug 15, 2024
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/entity/ScalePolicyDO.java
Outdated
Show resolved
Hide resolved
shenyu-admin/src/test/java/org/apache/shenyu/admin/mapper/ScaleRuleMapperTest.java
Outdated
Show resolved
Hide resolved
misaya295
previously approved these changes
Aug 16, 2024
|
you should add sql in upgrade script, for example, 2.6.1-2.7.0-mysql.sql, 2.6.1-2.7.0-pg.sql, and so on... |
moremind
requested changes
Sep 4, 2024
shenyu-admin/src/main/java/org/apache/shenyu/admin/controller/ScalePolicyController.java
Outdated
Show resolved
Hide resolved
shenyu-admin/src/main/java/org/apache/shenyu/admin/controller/ScaleRlueController.java
Outdated
Show resolved
Hide resolved
shenyu-admin/src/main/java/org/apache/shenyu/admin/controller/ScaleRlueController.java
Outdated
Show resolved
Hide resolved
shenyu-admin/src/main/java/org/apache/shenyu/admin/controller/ScaleRlueController.java
Outdated
Show resolved
Hide resolved
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/dto/ScalePolicyDTO.java
Outdated
Show resolved
Hide resolved
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/entity/ScalePolicyDO.java
Outdated
Show resolved
Hide resolved
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/vo/ScalePolicyVO.java
Show resolved
Hide resolved
shenyu-common/src/main/java/org/apache/shenyu/common/utils/DateUtils.java
Outdated
Show resolved
Hide resolved
done. |
misaya295
requested changes
Sep 4, 2024
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/dto/ScalePolicyDTO.java
Outdated
Show resolved
Hide resolved
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/dto/ScalePolicyDTO.java
Outdated
Show resolved
Hide resolved
moremind
previously approved these changes
Sep 7, 2024
misaya295
previously approved these changes
Sep 7, 2024
|
@Terminator111 check ci pls |
Terminator111
dismissed stale reviews from misaya295 and moremind
via
d08bcee
misaya295
reviewed
Sep 11, 2024
misaya295
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.