Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output Current Timestamp at run-class.sh script #1702

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Output Current Timestamp at run-class.sh script #1702

merged 3 commits into from
Aug 2, 2024

Conversation

yehaolan
Copy link
Contributor

@yehaolan yehaolan commented Jul 30, 2024 •
edited
Loading

Changes

  1. Fix the typo in the beam API documentation
  2. Print out the current timestamp at run-class.sh with stdout. Before making the change, which helps better monitor the job during container launch time, before container logs are available
  3. Fix the build issue, which has the same symptom mentioned in https://issues.apache.org/jira/browse/SAMZA-2786

Test

  • Tested in terminal:
$ echo "Current time: $(date '+%Y-%m-%d %H:%M:%S')"
Current time: 2024-07-29 17:20:03
  • Ran ./gradlew build sccessfully

@dxichen dxichen merged commit f9c3241 into apache:master Aug 2, 2024
1 check passed
MikeBarskii pushed a commit to MikeBarskii/samza that referenced this pull request Aug 6, 2024
@yehaolan @MikeBarskii
Output Current Timestamp at run-class.sh script (apache#1702)
1e84ac0 
* print current timestamp

* Fix typo

* fix build issue about grolifant okhttp

---------

Co-authored-by: Haolan Ye <hye@linkedin.com>
MikeBarskii pushed a commit to MikeBarskii/samza that referenced this pull request Aug 6, 2024
Revert "Output Current Timestamp at run-class.sh script (apache#1702)"
8e08a85 
This reverts commit 1e84ac0.
dxichen pushed a commit that referenced this pull request Aug 8, 2024
@MikeBarskii @yehaolan
Improve Samza AM retry count logging (#1701)
5b4b1b7 
* LISAMZA-43659 Improve Samza AM retry count logging

* Output Current Timestamp at run-class.sh script (#1702)

* print current timestamp

* Fix typo

* fix build issue about grolifant okhttp

---------

Co-authored-by: Haolan Ye <hye@linkedin.com>

* Revert "Output Current Timestamp at run-class.sh script (#1702)"

This reverts commit 1e84ac0.

---------

Co-authored-by: Michael Barskii <mbarskii@linkedin.com>
Co-authored-by: Haolan Ye <yehaolan@gmail.com>
Co-authored-by: Haolan Ye <hye@linkedin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dxichen dxichen dxichen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yehaolan @dxichen