Create store directory paths in CSM constructor for disk space monitor #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the disk usage of the store directories
dxichen
reviewed
Mar 28, 2024
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
Outdated
Show resolved
Hide resolved
dxichen
approved these changes
Apr 5, 2024
khandelwal-ayush
pushed a commit
to khandelwal-ayush/samza
that referenced
this pull request
Jun 12, 2024
apache#1697) (apache#43) * Create store directory paths in CSM constructor to be able to monitor the disk usage of the store directories * Fix stylecheck issues * Refactor - init all store paths together and do not mutate the storeDirPaths. Added test * Remove ununsed method * Remove ununsed method * Stylecheck, Remove ununsed import Co-authored-by: Shekhar Sharma <72765053+shekhars-li@users.noreply.github.com>
khandelwal-ayush
pushed a commit
to khandelwal-ayush/samza
that referenced
this pull request
Jun 12, 2024
…e monitor (apache#1697) (apache#43)" (apache#44) This reverts commit 01534ff. The above commit introduces a type change that is causing all builds to fail on samza-li. e.g. see samza-li e8b00bcba88cf9d235f8432309ef60c6ae1c7d74 Revert that commit in the short-term until we can address the type mismatch.
khandelwal-ayush
pushed a commit
to khandelwal-ayush/samza
that referenced
this pull request
Jun 12, 2024
* SAMZA-2797: Call flush during stop from CoordinatorStreamWriter (apache#1692) * SAMZA-2798: Populate worker.opts in environment variable only if available (apache#1693) Description Populate worker.opts in the environment variable only if available in the configs. Changes Check if worker.opts is present and then add it to environment variable Tests Updated unit tests * Add MAX_BACKGROUND_JOBS config for RocksDB (apache#1694) * SAMZA-2784: Remove excessive commit logs (apache#1695) * SAMZA-2799: Remove worker.opts handling in shell command builder (apache#1696) * Create store directory paths in CSM constructor for disk space monitor (apache#1697) * Create store directory paths in CSM constructor to be able to monitor the disk usage of the store directories * Fix stylecheck issues * Refactor - init all store paths together and do not mutate the storeDirPaths. Added test * Remove ununsed method * Remove ununsed method * Stylecheck, Remove ununsed import --------- Co-authored-by: ajo thomas <ajo.thomas24@gmail.com> Co-authored-by: Bharath Kumarasubramanian <bharathkk@apache.org> Co-authored-by: Shekhar Sharma <72765053+shekhars-li@users.noreply.github.com> Co-authored-by: Daniel Chen <xrchen@uwaterloo.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the bug: https://issues.apache.org/jira/browse/SAMZA-2752
What:
Set durable store names in a set in the ContainerStorageManager constructor
Why:
During previous refractoring, the createStore for durable stores was moved outside of constructor. However, the store directory paths are required to be set in constructor so that SamzaContainer class can set monitors for them. This patch sets the store names without creating the stores, so that monitoring can be set properly.