Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMZA-2798: Populate worker.opts in environment variable only if available #1693

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

mynameborat
Copy link
Contributor

Description
Populate worker.opts in the environment variable only if available in the configs.

Changes
Check if worker.opts is present and then add it to environment variable

Tests
Updated unit tests

API Changes: None

Upgrade Instructions: None

Usage Instructions: None

Copy link
Contributor

@ajothomas ajothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick patch.

@mynameborat mynameborat merged commit 8ed3572 into master Nov 22, 2023
1 of 2 checks passed
khandelwal-ayush pushed a commit to khandelwal-ayush/samza that referenced this pull request Jun 12, 2024
…lable (apache#1693)

Description
Populate worker.opts in the environment variable only if available in the configs.

Changes
Check if worker.opts is present and then add it to environment variable

Tests
Updated unit tests
khandelwal-ayush pushed a commit to khandelwal-ayush/samza that referenced this pull request Jun 12, 2024
* SAMZA-2797: Call flush during stop from CoordinatorStreamWriter (apache#1692)

* SAMZA-2798: Populate worker.opts in environment variable only if available (apache#1693)

Description
Populate worker.opts in the environment variable only if available in the configs.

Changes
Check if worker.opts is present and then add it to environment variable

Tests
Updated unit tests

* Add MAX_BACKGROUND_JOBS config for RocksDB (apache#1694)

* SAMZA-2784: Remove excessive commit logs (apache#1695)

* SAMZA-2799: Remove worker.opts handling in shell command builder (apache#1696)

---------

Co-authored-by: ajo thomas <ajo.thomas24@gmail.com>
Co-authored-by: Bharath Kumarasubramanian <bharathkk@apache.org>
Co-authored-by: Shekhar Sharma <72765053+shekhars-li@users.noreply.github.com>
Co-authored-by: Daniel Chen <xrchen@uwaterloo.ca>
khandelwal-ayush pushed a commit to khandelwal-ayush/samza that referenced this pull request Jun 12, 2024
* SAMZA-2797: Call flush during stop from CoordinatorStreamWriter (apache#1692)

* SAMZA-2798: Populate worker.opts in environment variable only if available (apache#1693)

Description
Populate worker.opts in the environment variable only if available in the configs.

Changes
Check if worker.opts is present and then add it to environment variable

Tests
Updated unit tests

* Add MAX_BACKGROUND_JOBS config for RocksDB (apache#1694)

* SAMZA-2784: Remove excessive commit logs (apache#1695)

* SAMZA-2799: Remove worker.opts handling in shell command builder (apache#1696)

* Create store directory paths in CSM constructor for disk space monitor (apache#1697)

* Create store directory paths in CSM constructor to be able to monitor the disk usage of the store directories

* Fix stylecheck issues

* Refactor - init all store paths together and do not mutate the storeDirPaths. Added test

* Remove ununsed method

* Remove ununsed method

* Stylecheck, Remove ununsed import

---------

Co-authored-by: ajo thomas <ajo.thomas24@gmail.com>
Co-authored-by: Bharath Kumarasubramanian <bharathkk@apache.org>
Co-authored-by: Shekhar Sharma <72765053+shekhars-li@users.noreply.github.com>
Co-authored-by: Daniel Chen <xrchen@uwaterloo.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants