Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract class refactoring. #167

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Vivek504
Copy link

Extract Class Refactoring

Location of the class: org.apache.pdfbox.examples.pdmodel.CreatePatternsPDF

Reason: Imperative Abstraction - The tool detected the smell in this class because it looks like that an operation is turned into a class. This class contains only the following public method: main

Logic of the refactoring: New class (PatternDrawer) is created to refactor the code and refactored code separates the responsibilities of two classes (CreatePatternsPDF and PatternDrawer).

@THausherr
Copy link
Contributor

This is an example class. There is no need to refactor it and create an additional class.

@Vivek504
Copy link
Author

Thanks for your quick feedback. I'll try to contribute if there is a need of refactoring any other class instead of Example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants