Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Polish] Refactor unify response logic #3833

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

[Polish] Refactor unify response logic #3833

wants to merge 8 commits into from

Conversation

GOODBOY008
Copy link
Member

@GOODBOY008 GOODBOY008 commented Jul 4, 2024 •
edited
Loading

Changes :

  • Polish response object
  • Unify response success and failure setter logic
  • Adjuest the logic to process response in front end (todo)

@GOODBOY008 GOODBOY008 marked this pull request as draft July 4, 2024 16:18
@GOODBOY008
Copy link
Member Author

@wolfboys Please take a look and give me some suggestions , Whether should I continue to work on it?

@wolfboys
Copy link
Member

wolfboys commented Jul 4, 2024

@wolfboys Please take a look and give me some suggestions , Whether should I continue to work on it?

It looks good to me, the code logic is clearer and more concise ~

@GOODBOY008 GOODBOY008 marked this pull request as ready for review July 25, 2024 16:15
@GOODBOY008 GOODBOY008 requested a review from wolfboys July 25, 2024 16:43
@GOODBOY008 GOODBOY008 force-pushed the dev-resp branch 3 times, most recently from 38c3183 to f33a1f0 Compare July 26, 2024 14:49
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfboys wolfboys Awaiting requested review from wolfboys

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BACKEND WEB UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GOODBOY008 @wolfboys