Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Revert the removal of repositories in the pom.xml file #2055

Closed
wants to merge 2 commits into from

Conversation

rodrigonull
Copy link
Contributor

@rodrigonull rodrigonull commented May 20, 2024

Removing the repositories from the pom.xml file caused errors when building kogito-apps:

02:09:29   @ 
02:09:29  [ERROR] The build could not read 1 project -> [Help 1]
02:09:29  [ERROR]   
02:09:29  [ERROR]   The project org.kie.kogito:kogito-apps:999-SNAPSHOT (/home/jenkins/workspace/KIE/kogito/main/other/kogito-apps.weekly-deploy/incubator-kie-kogito-apps/pom.xml) has 1 error
02:09:29  [ERROR]     Non-resolvable parent POM for org.kie.kogito:kogito-apps:999-SNAPSHOT: The following artifacts could not be resolved: org.kie.kogito:kogito-build-parent:pom:999-SNAPSHOT (absent): Could not find artifact org.kie.kogito:kogito-build-parent:pom:999-SNAPSHOT and 'parent.relativePath' points at no local POM @ line 28, column 11 -> [Help 2]

This PR reverts this change back to avoid having this error.

@jstastny-cz
Copy link
Contributor

I'd say don't revert, just add apache.snapshots into repositories to be able to resolve snapshot parents.
Reverting brings back the need to specify also Central, because Apache public group is there configured also for releases but had worse performance than central.

@jstastny-cz
Copy link
Contributor

E.g. look here:
https://github.com/apache/maven-parent/blob/master/pom.xml#L1001

<repositories>
    <!-- useful to resolve parent pom when it is a SNAPSHOT -->
    <repository>
      <releases>
        <enabled>false</enabled>
      </releases>
      <id>apache.snapshots</id>
      <name>Apache Snapshot Repository</name>
      <url>https://repository.apache.org/snapshots</url>
    </repository>
  </repositories>

@kie-ci3
Copy link
Contributor

kie-ci3 commented May 20, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2055 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2055/1/display/redirect

Test results:

  • PASSED: 1661
  • FAILED: 1

Those are the test failures:

org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobService java.util.ConcurrentModificationException
at java.base/java.util.ArrayList.forEach(ArrayList.java:1513)
at org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobService(EmbeddedJobsServiceTest.java:99)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:1013)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:827)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@rodrigonull rodrigonull deleted the revert-maven-repo branch August 27, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants