fix: set baseinvoker's url to nil to address memory leak issues #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…related references to avoid panic
fix:set url to nil when destroy base invoker
reafactor:add comment at BaseInvoker.Destroy()
|
binbin0325
reviewed
Aug 9, 2024
| func (bi *BaseInvoker) Destroy() { | ||
| logger.Infof("Destroy invoker: %s", bi.GetURL()) | ||
| bi.destroyed.Store(true) | ||
| bi.available.Store(false) | ||
| bi.url = nil |
There was a problem hiding this comment.
If set nil, is there any risk of a null pointer elsewhere
There was a problem hiding this comment.
set it nil to let the gc collect resource
There was a problem hiding this comment.
As u can see in other changed files, in other places whereurl are used, I changed the order, that is, destroyed them in the end to avoid null pointer issues; But still requires careful review;
georgehao
approved these changes
Aug 13, 2024
|
@chickenlj plz take the time to review this PR, thanks |
AlexStocks
approved these changes
Aug 16, 2024
FinalT
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bssed on PR #2223 ,the main purpose of this PR is to fix the memory leak problem caused by the url pointer in baseinvoker not being released correctly. You can refer to the following issue：
FIXES: #2701 #2339 #2031