Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature-16396][storage-plugin] Tencent Cloud COS Storage Plugin #16565

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

[Feature-16396][storage-plugin] Tencent Cloud COS Storage Plugin #16565

wants to merge 3 commits into from
+1,589 −75

Conversation

Mighten
Copy link

@Mighten Mighten commented Sep 2, 2024 •
edited
Loading

Purpose of the pull request

This pull request adds a Storage Plugin to the DS Resource Center to support Tencent Cloud COS and aims to close #16396 .

Brief change log

  • Add dolphinscheduler-storage-cos in dolphinscheduler-storage-plugin
  • Add qcloud cos_api to pom.xml files

Verify this pull request

Screenshot-ds

Screenshot-qcloud

Screenshot-tencent-cos-remote-logging

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Mighten Mighten changed the title [feature-16396][Resource Center] Tencent Cloud COS Storage Plugin [feature-16396][plugin] Tencent Cloud COS Storage Plugin Sep 2, 2024
@Mighten Mighten changed the title [feature-16396][plugin] Tencent Cloud COS Storage Plugin [Feature-16396][Storage-plugin] Tencent Cloud COS Storage Plugin Sep 2, 2024
@Mighten Mighten changed the title [Feature-16396][Storage-plugin] Tencent Cloud COS Storage Plugin [Feature-16396][storage-plugin] Tencent Cloud COS Storage Plugin Sep 2, 2024
SbloodyS
SbloodyS requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have any tencent cos support for integration testing. I will -1 on this until we can find a way to test against this in out UT, IT and E2E.

ruanwenjun
ruanwenjun reviewed Sep 2, 2024
View reviewed changes
dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/src/test/resources/logback.xml Show resolved Hide resolved
...eduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java
Comment on lines +395 to +397
public static final String TENCENT_CLOUD_ACCESS_KEY_ID = "resource.tencent.cloud.access.key.id";
public static final String TENCENT_CLOUD_ACCESS_KEY_SECRET = "resource.tencent.cloud.access.key.secret";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to storage plugin module

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your valuable opinions.

But I don't think placing these Tencent Credential Constants in the storage plugin is a good idea.

Cloud providers (Azure, Alibaba, Huawei, and Tencent) offer not only storage services but also other types of services.

Therefore, I believe Tencent Credential Constants should remain in task-plugin/task-api/org.apache.dolphinscheduler.plugin.task.api.TaskConstants, alongside the credential constants for other cloud providers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to storage plugin module

agree with @ruanwenjun ,Although the keys and secrets of various storage types are currently placed in the task-api module, I think this is unreasonable and should be placed in their own storage modules or in the storage-api module WDYT @Mighten cc @SbloodyS @rickchengx

image

dolphinscheduler-common/src/main/resources/common.properties Outdated Show resolved Hide resolved
@ruanwenjun ruanwenjun added the discussion discussion label Sep 2, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 6, 2024
View reviewed changes
...age-cos/src/main/java/org/apache/dolphinscheduler/plugin/storage/cos/CosStorageOperator.java
String cosKey = transformAbsolutePathToCOSKey(srcFilePath);

File dstFile = new File(dstFilePath);
if (dstFile.isDirectory()) {

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
Loading
.
...age-cos/src/main/java/org/apache/dolphinscheduler/plugin/storage/cos/CosStorageOperator.java

File dstFile = new File(dstFilePath);
if (dstFile.isDirectory()) {
Files.delete(dstFile.toPath());

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
Loading
.
@Mighten
Code Review updates:
40e5ff2 
* Fixed SonarCloud Quality Readability B (required >= A)
* Added missing license files
* YAML-ized Tencent COS configuration from common.properties
* Added remote logger support with Tencent COS
@fuchanghai
Copy link
Member

image we should remove bcprov-jdk15on-1.69

@Mighten
Code Review Update 2nd:
2d17bbd 
- Removed redundant dependency: `bcprov-jdk15on-1.69.jar`
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanwenjun ruanwenjun ruanwenjun left review comments

@fuchanghai fuchanghai fuchanghai left review comments

@SbloodyS SbloodyS SbloodyS requested changes

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@Gallardot Gallardot Awaiting requested review from Gallardot Gallardot is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@Mighten Mighten

Labels
backend discussion discussion document don't merge test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][resource center] Can the resource center support Tencent Cloud COS
4 participants
@Mighten @fuchanghai @SbloodyS @ruanwenjun