Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMEL-19182: camel-platform-http-starter - Async processing with Spring Boot #1199

Merged
merged 1 commit into from
Aug 21, 2024
Merged

CAMEL-19182: camel-platform-http-starter - Async processing with Spring Boot #1199

merged 1 commit into from
Aug 21, 2024

Conversation

kulagaIA
Copy link
Member

@kulagaIA kulagaIA commented Aug 20, 2024 •
edited
Loading

  • Spring MVC automatically detects CompletableFuture return type of the handler method and executes asynchronously; @ResponseBody on the handler method to disable attempts to resolve mvc view from a response.
  • testing async execution with MockMvc
  • @EnableAutoConfiguration instead of @SpringBootApplication on test classes to not scan another tests' configurations

Issue: https://issues.apache.org/jira/browse/CAMEL-19182

@kulagaIA kulagaIA force-pushed the async-processing-with-Spring-Boot branch from 43043e7 to d0b9be5 Compare August 21, 2024 09:29
@kulagaIA
Copy link
Member Author

Tests have failed because we run @DirtiesContext tests in parallel:
echo "MVND_OPTS=-V -e -ntp -Dmvnd.threads=2 -Daether.connector.http.connectionMaxTtl=120 -Daether.connector.requestTimeout=300000 -Daether.dependencyCollector.impl=bf -Dmaven.artifact.threads=25 -Dci.env.name=github.com -Dsurefire.rerunFailingTestsCount=2 -Dfailsafe.rerunFailingTestsCount=2" >> $GITHUB_ENV.
Should we edit tests or build job?

@Croway
Copy link
Contributor

Croway commented Aug 21, 2024

Tests have failed because we run @DirtiesContext tests in parallel: echo "MVND_OPTS=-V -e -ntp -Dmvnd.threads=2 -Daether.connector.http.connectionMaxTtl=120 -Daether.connector.requestTimeout=300000 -Daether.dependencyCollector.impl=bf -Dmaven.artifact.threads=25 -Dci.env.name=github.com -Dsurefire.rerunFailingTestsCount=2 -Dfailsafe.rerunFailingTestsCount=2" >> $GITHUB_ENV. Should we edit tests or build job?

is the failure related to Failed to start route myget because of duplicate id detected: myget? In case can you use UUIDs or test class/name?

@kulagaIA kulagaIA force-pushed the async-processing-with-Spring-Boot branch from d0b9be5 to 7dd74bb Compare August 21, 2024 11:03
@kulagaIA
CAMEL-19182: camel-platform-http-starter - Async processing with Spri…
7dd74bb 
…ng Boot

- Spring MVC automatically detects CompletableFuture return type of the handler method and executes asynchronously; @responsebody on the handler method to disable attempts to resolve mvc view from a response.
- testing async execution with MockMvc
- @EnableAutoConfiguration instead of @SpringBootApplication on test classes to not scan another tests' configurations
@kulagaIA
Copy link
Member Author

is the failure related to Failed to start route myget because of duplicate id detected: myget? In case can you use UUIDs or test class/name?

Changed tests to have unique route id's

@davsclaus davsclaus merged commit ed5530a into apache:main Aug 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davsclaus davsclaus davsclaus approved these changes

@Croway Croway Croway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kulagaIA @Croway @davsclaus