fix(ci): Removed STAGING_RUNTIME_REPO from Makefile #5641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jun 17, 2024
squakez
reviewed
Jun 17, 2024
e2e/support/test_staging_hooks.go
Outdated
| @@ -30,16 +30,14 @@ import ( | |||
| ) | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
Probably the entire init() func can be removed to avoid the build error.
There was a problem hiding this comment.
I have removed init function, Is it correct now?
There was a problem hiding this comment.
Thanks. However I noticed I was wrong. In the diff code snippet I did not see that the func is also having a second part with more logic. We need to restore it and just get rid of the build error. In order to verify that, you should try to build locally before submitting the change. Just do make build and you should compile successfully before submitting the PR.
|
Superseded by #5719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5616,
Removed STAGING_RUNTIME_REPO from Makefile and
test_staging_hooks.go. Please let me know, if there are any changes needed.