Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(traits): use Comparable matches #5230

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix(traits): use Comparable matches #5230

merged 1 commit into from
Mar 12, 2024

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Mar 7, 2024

Reverting #4512 which introduced a function diverging the match from the original design

This PR aims to fix a diverging design I introduced some times ago. With this one we move back to the original design making correct usage of Comparable interface in trait which is used by the operator to distinguish when to reuse or rebuild an Integration based only on certain IntegrationKit traits changes (ie, runtime version, builder properties).

Release Note

fix(traits): use Comparable matches

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

✔️ Unit test coverage report - coverage increased from 36.8% to 37% (+0.2%)

lburgazzoli
lburgazzoli reviewed Mar 7, 2024
View reviewed changes
pkg/trait/builder.go Outdated Show resolved Hide resolved
@squakez squakez added the trigger native test Use this label in PR when you want to trigger Quarkus Native tests label Mar 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

✔️ Unit test coverage report - coverage increased from 36.9% to 37.1% (+0.2%)

@squakez
Copy link
Contributor Author

squakez commented Mar 8, 2024 

--- PASS: TestNativeHighMemoryIntegrations (1750.79s)
    --- PASS: TestNativeHighMemoryIntegrations/java_native_support (847.92s)
        --- PASS: TestNativeHighMemoryIntegrations/java_native_support/java_native_same_should_not_rebuild (2.22s)
        --- PASS: TestNativeHighMemoryIntegrations/java_native_support/java_native_should_rebuild (417.19s)
    --- PASS: TestNativeHighMemoryIntegrations/groovy_native_support (457.62s)
    --- PASS: TestNativeHighMemoryIntegrations/kotlin_native_support (434.65s)
PASS
ok  	github.com/apache/camel-k/v2/e2e/native	1750.826s
--- PASS: TestNativeBinding (435.95s)
    --- PASS: TestNativeBinding/binding_with_native_build (421.78s)
--- PASS: TestNativeIntegrations (846.09s)
    --- PASS: TestNativeIntegrations/unsupported_integration_source_language (0.80s)
    --- PASS: TestNativeIntegrations/xml_native_support (410.86s)
    --- PASS: TestNativeIntegrations/automatic_rollout_deployment_from_jvm_to_native_kit (424.50s)
        --- PASS: TestNativeIntegrations/automatic_rollout_deployment_from_jvm_to_native_kit/yaml_native_should_not_rebuild (2.76s)
PASS
ok  	github.com/apache/camel-k/v2/e2e/native	1282.082s
``

@squakez squakez force-pushed the fix/trait_compares branch 2 times, most recently from 0387be0 to 56803ef Compare March 11, 2024 14:55
@github-actions GitHub Actions
Copy link
Contributor

✔️ Unit test coverage report - coverage increased from 36.9% to 37.1% (+0.2%)

@squakez
fix(traits): use Comparable matches
d801fe9 
Reverting apache#4512 which introduced a function diverging the match from the original design
@github-actions GitHub Actions
Copy link
Contributor

✔️ Unit test coverage report - coverage increased from 36.9% to 37.1% (+0.2%)

@squakez squakez merged commit 0725b40 into apache:main Mar 12, 2024
13 of 15 checks passed
@squakez squakez deleted the fix/trait_compares branch March 12, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lburgazzoli lburgazzoli lburgazzoli approved these changes

@oscerd oscerd oscerd approved these changes

@gansheer gansheer gansheer approved these changes

Assignees
No one assigned
Labels
trigger native test Use this label in PR when you want to trigger Quarkus Native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@squakez @lburgazzoli @oscerd @gansheer