Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cron trait doc, timer usage is missing information #4633

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

claudio4j
Copy link
Contributor

Fix doc related to when the timer is materialized as a CronJOb

Release Note

NONE

@claudio4j claudio4j force-pushed the fix_cron branch 2 times, most recently from fe53a42 to 2ef6194 Compare August 1, 2023 22:14
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

Fix doc related to when the timer is materialized as a CronJOb
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@@ -27,8 +27,11 @@ package trait
// Integrations that start from the following components are evaluated by the cron trait: `timer`, `cron`, `quartz`.
//
// The rules for using a Kubernetes CronJob are the following:
// - `timer`: when periods can be written as cron expressions. E.g. `timer:tick?period=60000`.
//
// - `timer`: when period is set in milliseconds with no remaining seconds, for example 120000. If there is any second left as in 121000 (120s and 1s) or the presence of any of these parameters (delay, repeatCount, time) then a CronJob won't be created, but a standard deployment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity. Where is this behavior defined? in the runtime?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is defined partly in the cron.go trait and the camel-k-cron (camel-k-runtime).

@claudio4j claudio4j merged commit 85464ba into apache:main Aug 2, 2023
17 checks passed
@claudio4j claudio4j deleted the fix_cron branch August 2, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants