fix: remove PROBLEMATIC tests flag and reporting

* remove CAMEL_K_TEST_SKIP_PROBLEMATIC var * remove problematic reporting Co-authored-by: Jono Morris <jono@apache.org>
apache · Jul 2, 2024 · 555dffb · 555dffb
1 parent 59aca7b
commit 555dffb
Show file tree

Hide file tree

Showing 23 changed files with 2 additions and 250 deletions.
diff --git a/.github/actions/e2e-builder/action.yml b/.github/actions/e2e-builder/action.yml
@@ -103,12 +103,6 @@ runs:
       image-registry-insecure: ${{steps.config-cluster.outputs.cluster-image-registry-insecure }}
       image-version: ${{ steps.build-kamel.outputs.build-binary-local-image-version }}
 
-  - id: report-problematic
-    name: List Tests Marked As Problematic
-    uses: ./.github/actions/kamel-report-problematic
-    with:
-      test-suite: global/builder
-
   - id: run-it
     name: Run IT
     shell: bash

diff --git a/.github/actions/e2e-common/action.yml b/.github/actions/e2e-common/action.yml
@@ -107,12 +107,6 @@ runs:
       image-registry-insecure: ${{steps.config-cluster.outputs.cluster-image-registry-insecure }}
       image-version: ${{ steps.build-kamel.outputs.build-binary-local-image-version }}
 
-  - id: report-problematic
-    name: List Tests Marked As Problematic
-    uses: ./.github/actions/kamel-report-problematic
-    with:
-      test-suite: global/common
-
   - id: run-it
     name: Run IT
     shell: bash

diff --git a/.github/actions/e2e-install-olm/action.yml b/.github/actions/e2e-install-olm/action.yml
@@ -95,12 +95,6 @@ runs:
       catalog-source-name: ${{ steps.config-cluster.outputs.cluster-catalog-source-name }}
       catalog-source-namespace: ${{ steps.config-cluster.outputs.cluster-catalog-source-namespace }}
 
-  - id: report-problematic
-    name: List Tests Marked As Problematic
-    uses: ./.github/actions/kamel-report-problematic
-    with:
-      test-suite: namespace/upgrade
-
   - name: Run IT
     shell: bash
     run: |

diff --git a/.github/actions/e2e-install-upgrade/action.yml b/.github/actions/e2e-install-upgrade/action.yml
@@ -95,12 +95,6 @@ runs:
       catalog-source-name: ${{ steps.config-cluster.outputs.cluster-catalog-source-name }}
       catalog-source-namespace: ${{ steps.config-cluster.outputs.cluster-catalog-source-namespace }}
 
-  - id: report-problematic
-    name: List Tests Marked As Problematic
-    uses: ./.github/actions/kamel-report-problematic
-    with:
-      test-suite: namespace/upgrade
-
   - name: Run IT
     shell: bash
     run: |

diff --git a/.github/actions/e2e-install/action.yml b/.github/actions/e2e-install/action.yml
@@ -86,12 +86,6 @@ runs:
       image-registry-insecure: ${{steps.config-cluster.outputs.cluster-image-registry-insecure }}
       image-version: ${{ steps.build-kamel.outputs.build-binary-local-image-version }}
 
-  - id: report-problematic
-    name: List Tests Marked As Problematic
-    uses: ./.github/actions/kamel-report-problematic
-    with:
-      test-suite: namespace/install
-
   - id: run-it
     name: Run IT
     shell: bash

diff --git a/.github/actions/e2e-knative-yaks/action.yml b/.github/actions/e2e-knative-yaks/action.yml
@@ -108,12 +108,6 @@ runs:
       image-name: "docker.io/citrusframework/yaks"
       version: 0.19.1
 
-  - id: report-problematic
-    name: List Tests Marked As Problematic
-    uses: ./.github/actions/kamel-report-problematic
-    with:
-      test-suite: yaks/common
-
   - id: run-it
     name: Run IT
     shell: bash

diff --git a/.github/actions/e2e-knative/action.yml b/.github/actions/e2e-knative/action.yml
@@ -103,12 +103,6 @@ runs:
       image-registry-insecure: ${{steps.config-cluster.outputs.cluster-image-registry-insecure }}
       image-version: ${{ steps.build-kamel.outputs.build-binary-local-image-version }}
 
-  - id: report-problematic
-    name: List Tests Marked As Problematic
-    uses: ./.github/actions/kamel-report-problematic
-    with:
-      test-suite: global/knative
-
   - id: run-it
     name: Run IT
     shell: bash

diff --git a/.github/actions/e2e-native/action.yml b/.github/actions/e2e-native/action.yml
@@ -86,12 +86,6 @@ runs:
       image-registry-insecure: ${{steps.config-cluster.outputs.cluster-image-registry-insecure }}
       image-version: ${{ steps.build-kamel.outputs.build-binary-local-image-version }}
 
-  - id: report-problematic
-    name: List Tests Marked As Problematic
-    uses: ./.github/actions/kamel-report-problematic
-    with:
-      test-suite: namespace/native
-
   - id: run-it
     name: Run IT
     shell: bash

diff --git a/.github/actions/e2e-telemetry/action.yml b/.github/actions/e2e-telemetry/action.yml
@@ -105,12 +105,6 @@ runs:
       otlp-collector-image-name: otel/opentelemetry-collector
       otlp-collector-image-version: 0.102.0
 
-  - id: report-problematic
-    name: List Tests Marked As Problematic
-    uses: ./.github/actions/kamel-report-problematic
-    with:
-      test-suite: global/common
-
   - id: run-it
     name: Run IT
     shell: bash

diff --git a/.github/actions/kamel-report-problematic/action.yml b/.github/actions/kamel-report-problematic/action.yml
diff --git a/.github/actions/kamel-report-problematic/report-problematic.sh b/.github/actions/kamel-report-problematic/report-problematic.sh
diff --git a/.github/workflows/builder.yml b/.github/workflows/builder.yml
@@ -56,10 +56,6 @@ on:
       pre-built-kamel-image:
         description: 'Kamel image url for skipping building of kamel stages. Used for debugging'
         required: false
-      skip-problematic:
-        description: 'Whether tests marked as problematic should be skipped - false by default (sets CAMEL_K_TEST_SKIP_PROBLEMATIC)'
-        required: false
-        default: false
       test-filters:
         description: |
           Filter the tests in this test suite by assigning the test pattern to TEST_KNATIVE_RUN,
@@ -90,7 +86,6 @@ jobs:
       run: |
         ./.github/workflows/manual-exec-process-inputs.sh \
           -i "${{ github.event.inputs.pre-built-kamel-image }}" \
-          -p "${{ github.event.inputs.skip-problematic }}" \
           -q "${{ github.event.inputs.log-level }}" \
           -t "${{ github.event.inputs.test-filters }}"
 

diff --git a/.github/workflows/common.yml b/.github/workflows/common.yml
@@ -59,10 +59,6 @@ on:
       pre-built-kamel-image:
         description: 'Kamel image url for skipping building of kamel stages. Used for debugging'
         required: false
-      skip-problematic:
-        description: 'Whether tests marked as problematic should be skipped - false by default (sets CAMEL_K_TEST_SKIP_PROBLEMATIC)'
-        required: false
-        default: false
       test-filters:
         description: |
           List of comma-separated key/value pairs to filter the tests in this test suite:
@@ -91,7 +87,6 @@ jobs:
       run: |
         ./.github/workflows/manual-exec-process-inputs.sh \
           -i "${{ github.event.inputs.pre-built-kamel-image }}" \
-          -p "${{ github.event.inputs.skip-problematic }}" \
           -q "${{ github.event.inputs.log-level }}" \
           -t "${{ github.event.inputs.test-filters }}"
     - name: Common tests
@@ -114,7 +109,6 @@ jobs:
       run: |
         ./.github/workflows/manual-exec-process-inputs.sh \
           -i "${{ github.event.inputs.pre-built-kamel-image }}" \
-          -p "${{ github.event.inputs.skip-problematic }}" \
           -q "${{ github.event.inputs.log-level }}" \
           -t "${{ github.event.inputs.test-filters }}"
     - name: Common advanced tests

diff --git a/.github/workflows/install.yml b/.github/workflows/install.yml
@@ -57,10 +57,6 @@ on:
       pre-built-kamel-image:
         description: 'Kamel image url for skipping building of kamel stages. Used for debugging'
         required: false
-      skip-problematic:
-        description: 'Whether tests marked as problematic should be skipped - false by default (sets CAMEL_K_TEST_SKIP_PROBLEMATIC)'
-        required: false
-        default: false
       test-filters:
         description: |
           List of comma-separated key/value pairs to filter the tests in this test suite:
@@ -95,7 +91,6 @@ jobs:
       run: |
         ./.github/workflows/manual-exec-process-inputs.sh \
           -i "${{ github.event.inputs.pre-built-kamel-image }}" \
-          -p "${{ github.event.inputs.skip-problematic }}" \
           -q "${{ github.event.inputs.log-level }}" \
           -t "${{ github.event.inputs.test-filters }}"
 
@@ -119,7 +114,6 @@ jobs:
       run: |
         ./.github/workflows/manual-exec-process-inputs.sh \
           -i "${{ github.event.inputs.pre-built-kamel-image }}" \
-          -p "${{ github.event.inputs.skip-problematic }}" \
           -q "${{ github.event.inputs.log-level }}" \
           -t "${{ github.event.inputs.test-filters }}"
 
@@ -143,7 +137,6 @@ jobs:
       run: |
         ./.github/workflows/manual-exec-process-inputs.sh \
           -i "${{ github.event.inputs.pre-built-kamel-image }}" \
-          -p "${{ github.event.inputs.skip-problematic }}" \
           -q "${{ github.event.inputs.log-level }}" \
           -t "${{ github.event.inputs.test-filters }}"
 

diff --git a/.github/workflows/knative.yml b/.github/workflows/knative.yml
@@ -55,10 +55,6 @@ on:
       pre-built-kamel-image:
         description: 'Kamel image url for skipping building of kamel stages. Used for debugging'
         required: false
-      skip-problematic:
-        description: 'Whether tests marked as problematic should be skipped - false by default (sets CAMEL_K_TEST_SKIP_PROBLEMATIC)'
-        required: false
-        default: false
       test-filters:
         description: |
           Filter the tests in this test suite by assigning the test pattern to TEST_KNATIVE_RUN,
@@ -84,7 +80,6 @@ jobs:
       run: |
         ./.github/workflows/manual-exec-process-inputs.sh \
           -i "${{ github.event.inputs.pre-built-kamel-image }}" \
-          -p "${{ github.event.inputs.skip-problematic }}" \
           -q "${{ github.event.inputs.log-level }}" \
           -t "${{ github.event.inputs.test-filters }}"
 

diff --git a/.github/workflows/manual-exec-process-inputs.sh b/.github/workflows/manual-exec-process-inputs.sh
@@ -32,9 +32,6 @@ while getopts ":i:p:q:t:" opt; do
     i)
       PRE_BUILT_IMAGE=${OPTARG}
       ;;
-    p)
-      SKIP_PROBLEMATIC=${OPTARG}
-      ;;
     q)
       LOG_LEVEL=${OPTARG}
       ;;
@@ -61,13 +58,6 @@ if [ -n "${PRE_BUILT_IMAGE}" ]; then
   echo "DEBUG_USE_EXISTING_IMAGE=${PRE_BUILT_IMAGE}" >> $GITHUB_ENV
 fi
 
-#
-# Avoid problematic tests only if parameter set to true
-#
-if [ "${SKIP_PROBLEMATIC}" == "true" ]; then
-  echo "CAMEL_K_TEST_SKIP_PROBLEMATIC=true" >> $GITHUB_ENV
-fi
-
 #
 # Adds -run args to filter tests in test suites
 #

diff --git a/.github/workflows/native.yml b/.github/workflows/native.yml
@@ -60,10 +60,6 @@ on:
       pre-built-kamel-image:
         description: 'Kamel image url for skipping building of kamel stages. Used for debugging'
         required: false
-      skip-problematic:
-        description: 'Whether tests marked as problematic should be skipped - false by default (sets CAMEL_K_TEST_SKIP_PROBLEMATIC)'
-        required: false
-        default: false
       test-filters:
         description: |
           Filter the tests in this test suite by assigning the test pattern to TEST_NATIVE_RUN,
@@ -89,7 +85,6 @@ jobs:
       run: |
         ./.github/workflows/manual-exec-process-inputs.sh \
           -i "${{ github.event.inputs.pre-built-kamel-image }}" \
-          -p "${{ github.event.inputs.skip-problematic }}" \
           -q "${{ github.event.inputs.log-level }}" \
           -t "${{ github.event.inputs.test-filters }}"
     - name: Quarkus Native test