Upgrade bootstrap version from 3 to 5 #398
Conversation
# Conflicts: # _layouts/default.html
|
Removing "WIP" as I think I've done everything that I can tell needs to be done for this upgrade. All screenshots should be current so if anything looks off let me know. The last thing was fixing the navbar which turns into a dropdown on small screens. This was fixed in 254cd06. main: with these changes: |
DomGarguilo
changed the title
DomGarguilo
force-pushed
the
upgradeBootstrap
branch
from
f5fccb8
to
b266e5c
Compare
There was a problem hiding this comment.
Overall, looks good, but I would suggest trying to preserve the previous structure of the downloads page buttons, because I think the changes here will cause the buttons to wrap more poorly than they currently do. I remember spending a lot of effort to get them to wrap just right, so everything looked good on mobile (or just small screens) and on a regular sized screen, and I think some of the structural changes to the div tags breaks some of that.
Everything else on the site seems good, though.
Partially addresses #394
Upgrades the bootstrap version from 3.3.7 to 5.3.1
A lot of classes have changed between versions and some new css was added to maintain the styling after upgrading to version 5.
Here are some screenshots showing various pages before and after these changes. I will replace each image with a new screenshot if I end up making more changes.
Current:
New with these changes:
Current:
New with these changes:
Current:
New with these changes:
Current:
New with these changes:
Current:
New with these changes:
Current:
New with these changes:
Current:
New with these changes:
Current:
New with these changes:
Current:
New with these changes:
Current:
New with these changes:
Current:
New with these changes:
Current:
New with these changes: