integrate platform Java SDK into space-gateway #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(ci): add global container registry
chore(yaml): build-push-image.yaml
wzzc-dev
reviewed
Sep 20, 2023
| } | ||
| } | ||
|
|
||
| public UserRegistryResult registerUser(String requestId, UserRegistryInfo userRegistryInfo, String boxRegKey) { |
There was a problem hiding this comment.
这里注册用户可以直接把 obtainBoxRegKey 也一起请求，这样调用的时候 只调用 registerUser 就可以了
| @@ -89,10 +99,12 @@ public PlatformInfo setPlatform(String ssplatformUrl){ | |||
| **/ | |||
| @Logged | |||
| @Transactional | |||
| public UserRegistryResult registryUser(String requestId, UserRegistryInfo userRegistryInfo, Boolean platformRegistry) { | |||
| public UserRegistryResult registryUser(String requestId, UserRegistryInfo userRegistryInfo, Boolean platformRegistry) throws Exception { | |||
There was a problem hiding this comment.
这里抛出的一场可以 try catch 捕获下 打印错误日志 然后 throw new ServiceOperationException()
| this.client = new Client(host, null); | ||
| } | ||
|
|
||
| public String obtainBoxRegKey(String requestId) { |
There was a problem hiding this comment.
boxRegKey 的 申请可以 设置一个缓存时间 三分钟或五分钟，小于平台侧设置的有效时间就可以，没必要每次申请
ren2003u
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a single class to instantiate sdk client and call client's method in registry user method.