Skip to content

Commit

Permalink
Implement interim solution with SST parameters (ShipSoft#490)
Browse files Browse the repository at this point in the history
* Implement interim solution with SST parameters

Retain plane parameters for SST momentarily

* Update strawtubes.h to allow using non-integer stereo angles

* Fix issue with SST parameters (ShipSoft#489)
  • Loading branch information
wcmartylee committed Aug 29, 2024
1 parent 045d67a commit b5fea3b
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ it in future.

* Remove trailing whitespace and fix line endings
* Fix compilation warnings due to deprecations #469
* Fix issue with SST parameters #489

### Changed

Expand Down
2 changes: 2 additions & 0 deletions geometry/geometry_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,9 @@
c.strawtubes.InnerStrawDiameter = 1.9928 * u.cm
c.strawtubes.StrawPitch = 2. * u.cm
c.strawtubes.DeltazLayer = 1.732 * u.cm
c.strawtubes.DeltazPlane = 0 * u.cm
c.strawtubes.YLayerOffset = 1. * u.cm
c.strawtubes.YPlaneOffset = 0 * u.cm
c.strawtubes.FrameMaterial = "steel"
c.strawtubes.FrameLateralWidth = 0.25 * u.m
c.strawtubes.DeltazFrame = 2.5 * u.cm
Expand Down
8 changes: 4 additions & 4 deletions strawtubes/strawtubes.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ void strawtubes::SetStrawsPerLayer(Int_t strawsperlayer)
fStraws_per_layer = strawsperlayer; //! number of straws in one layer
}

void strawtubes::SetStereoAngle(Int_t stereoangle)
void strawtubes::SetStereoAngle(Double_t stereoangle)
{
fView_angle = stereoangle; //! Stereo angle of planes in a view
fcosphi=cos(TMath::Pi()*fView_angle/180.);
Expand Down Expand Up @@ -478,7 +478,7 @@ void strawtubes::ConstructGeometry()

TGeoTranslation t5p;

for (Int_t pnb=0; pnb<2; pnb++) {
for (Int_t pnb=0; pnb<1; pnb++) {
//plane loop
TString nmplane_veto = nmveto+"_plane_"; nmplane_veto += pnb;
//width of the planes: z distance between layers + outer straw diameter
Expand Down Expand Up @@ -620,7 +620,7 @@ void strawtubes::ConstructGeometry()
vac_12->AddNode(viewframe_12, statnb*10000000+vnb*1000000,h5);
viewframe_12->SetLineColor(kRed);

for (Int_t pnb=0; pnb<2; pnb++) {
for (Int_t pnb=0; pnb<1; pnb++) {
//plane loop
TString nmplane_12 = nmview_12+"_plane_";
nmplane_12 += pnb;
Expand Down Expand Up @@ -717,7 +717,7 @@ void strawtubes::ConstructGeometry()
vac->AddNode(viewframe, statnb*10000000+vnb*1000000,h5);
viewframe->SetLineColor(kRed);

for (Int_t pnb=0; pnb<2; pnb++) {
for (Int_t pnb=0; pnb<1; pnb++) {
//plane loop
TString nmplane = nmview+"_plane_";
nmplane += pnb;
Expand Down
2 changes: 1 addition & 1 deletion strawtubes/strawtubes.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class strawtubes: public FairDetector
void SetDeltazLayer(Double_t deltazlayer);
void SetDeltazPlane(Double_t deltazplane);
void SetStrawsPerLayer(Int_t strawsperlayer);
void SetStereoAngle(Int_t stereoangle);
void SetStereoAngle(Double_t stereoangle);
void SetWireThickness(Double_t wirethickness);
void SetDeltazFrame(Double_t deltazframe);
void SetFrameLateralWidth(Double_t framelateralwidth);
Expand Down

0 comments on commit b5fea3b

Please sign in to comment.