added hot reload to receptor config #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## devel #1135 +/- ##
========================================
Coverage ? 43.43%
========================================
Files ? 36
Lines ? 7192
Branches ? 0
========================================
Hits ? 3124
Misses ? 3829
Partials ? 239
|
resoluteCoder
force-pushed
the
hot-reload-config
branch
2 times, most recently
from
03e92e0
to
68fd0de
Compare
resoluteCoder
force-pushed
the
hot-reload-config
branch
from
68fd0de
to
bf5d63a
Compare
AaronH88
reviewed
Sep 6, 2024
AaronH88
reviewed
Sep 6, 2024
AaronH88
reviewed
Sep 6, 2024
AaronH88
reviewed
Sep 6, 2024
AaronH88
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Overall looking good,
I would like a few more comments around the reflection function to make it quicker to read once we revisit later
The functionality looks good to me,
@thom-at-redhat and @matoval can you look also please
resoluteCoder
force-pushed
the
hot-reload-config
branch
from
85a353d
to
b73a6bb
Compare
matoval
reviewed
Sep 6, 2024
matoval
reviewed
Sep 6, 2024
matoval
reviewed
Sep 6, 2024
matoval
reviewed
Sep 6, 2024
resoluteCoder
force-pushed
the
hot-reload-config
branch
from
46b0c5b
to
3e9576c
Compare
|
matoval
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.