Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests & refactor tx crate #3835

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

add tests & refactor tx crate #3835

wants to merge 6 commits into from

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Sep 20, 2024

Describe your changes

related to #1497

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 78.84131% with 168 lines in your changes missing coverage. Please review.

Project coverage is 72.94%. Comparing base (be38d4c) to head (5e283f6).

Files with missing lines Patch % Lines
crates/tx/src/section.rs 68.09% 141 Missing ⚠️
crates/tx/src/sign.rs 80.99% 23 Missing ⚠️
crates/tx/src/types.rs 98.26% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3835      +/-   ##
==========================================
+ Coverage   72.82%   72.94%   +0.11%     
==========================================
  Files         338      339       +1     
  Lines      104220   104454     +234     
==========================================
+ Hits        75897    76191     +294     
+ Misses      28323    28263      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant