Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more tests #3704

Merged
merged 7 commits into from
Aug 28, 2024
Merged

more tests #3704

merged 7 commits into from
Aug 28, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Aug 27, 2024

Describe your changes

related to #1497

Depends-On: #3697

  • add couple basic tests in core
  • removes "integration" feature

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

Copy link
Contributor

mergify bot commented Aug 27, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 93.85965% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.08%. Comparing base (a899f28) to head (c7ea77d).
Report is 9 commits behind head on main.

Files Patch % Lines
crates/merkle_tree/src/lib.rs 0.00% 2 Missing ⚠️
crates/node/src/shell/init_chain.rs 66.66% 2 Missing ⚠️
crates/node/src/shell/mod.rs 77.77% 2 Missing ⚠️
crates/core/src/chain.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3704      +/-   ##
==========================================
+ Coverage   61.50%   63.08%   +1.57%     
==========================================
  Files         315      309       -6     
  Lines      103879   101491    -2388     
==========================================
+ Hits        63891    64022     +131     
+ Misses      39988    37469    -2519     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic
Copy link
Member Author

I rm'd the "integration" feature in 9dc5a13, but in CI it's still running with --feature integration from main so this is expected to fail

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Fraccaman Fraccaman self-requested a review August 28, 2024 11:43
@tzemanovic tzemanovic merged commit be74d20 into main Aug 28, 2024
18 of 20 checks passed
@tzemanovic tzemanovic deleted the tomas/more-tests branch August 28, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants