Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rough form for IBC withdrawals #1133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emccorson
Copy link
Collaborator

@emccorson emccorson commented Sep 20, 2024

This PR adds another very rough IBC prototype, this time for IBC transfers from Namada to Cosmos.

Note: The tx details are not dislaying properly in the extension, but as far as I know we need to get the IBC WASM hash from the indexer to do this, which it is currently not sending. anoma/namada-indexer#120

Testing

  1. Set up hermes as in https://hackmd.io/a95Q2m6TRM-ntjFSSPzKTA (make sure to use theta-testnet-001 as the Cosmos testnet)
  2. Send some NAM to using the form
  3. Check you received the NAM on the Cosmos side with gaiad query bank balances <cosmos address> --node https://rpc-t.cosmos.nodestake.top/

@emccorson emccorson marked this pull request as ready for review September 20, 2024 14:55
@mateuszjasiuk
Copy link
Collaborator

As a side note. I've just added tx_ibc checksums to the indexer.

Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test it until the end because of the "Per-epoch throughput limit", but I'm pretty sure it works fine. I also got an error when channel became inactive so I think all is good 👍

import { getFirstError } from "atoms/utils";

const keplr = (window as KeplrWindow).keplr!;
const namada = (window as WindowWithNamada).namada!;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing I had to move this inside submitIbcTransfer otherwise it was sometimes undefined :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants