fix: fix vote button being incorrectly disabled #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
requested review from
jurevans,
euharrison,
pedrorezende and
mateuszjasiuk
jurevans
approved these changes
Sep 18, 2024
emccorson
force-pushed
the
react-query-undefined-voting-fix
branch
from
dd1c0a7
to
efcb385
Compare
This was caused by returning undefined from react query to signal that the user has no existing vote, but returning undefined is disallowed by react query.
emccorson
force-pushed
the
react-query-undefined-voting-fix
branch
from
efcb385
to
9856bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by returning undefined from react query to signal that the user has no existing vote, but returning undefined is disallowed by react query.