feat: Faucet - Make extension connection optional #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking loud... we should increase the contrast of the fields
|
|
Not sure if it's me only but I found hidden message :) |
mateuszjasiuk
approved these changes
Sep 13, 2024
Good catch! I can fix that |
jurevans
force-pushed
the
feat/faucet-should-not-require-extension
branch
from
bc20fe8
to
234a8bf
Compare
jurevans
added a commit
that referenced
this pull request
Sep 14, 2024
* feat: make extension optional * fix: remove unneeded message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of the faucet app have had issues using it when the accounts they need to fund are generate in the CLI.
This update removes the need to connect the extension to access your accounts, but it is still an option.