fix: code review fixes

apps/namadillo/src/atoms/accounts/atoms.ts

@@ -1,12 +1,13 @@
 import { getIntegration } from "@namada/integrations";
 import { Account } from "@namada/types";
 import { indexerApiAtom } from "atoms/api";
-import { chainConfigAtom, nativeTokenAddressAtom } from "atoms/chain";
+import { nativeTokenAddressAtom } from "atoms/chain";
 import { shouldUpdateBalanceAtom } from "atoms/etc";
 import { namadaExtensionConnectedAtom } from "atoms/settings";
 import { queryDependentFn } from "atoms/utils";
 import BigNumber from "bignumber.js";
 import { atomWithMutation, atomWithQuery } from "jotai-tanstack-query";
+import { chainConfigByName } from "registry";
 import {
   fetchAccountBalance,
   fetchAccounts,
@@ -50,7 +51,7 @@ export const accountBalanceAtom = atomWithQuery<BigNumber>((get) => {
   const tokenAddress = get(nativeTokenAddressAtom);
   const enablePolling = get(shouldUpdateBalanceAtom);
   const api = get(indexerApiAtom);
-  const chainConfig = get(chainConfigAtom("namada"));
+  const chainConfig = chainConfigByName("namada");
 
   return {
     // TODO: subscribe to indexer events when it's done

apps/namadillo/src/atoms/chain/atoms.ts

@@ -7,10 +7,7 @@ import {
 } from "atoms/settings";
 import { queryDependentFn } from "atoms/utils";
 import BigNumber from "bignumber.js";
-import { atom } from "jotai";
 import { atomWithQuery } from "jotai-tanstack-query";
-import { atomFamily } from "jotai/utils";
-import { ChainConfig, chainConfigByName } from "registry";
 import { ChainParameters, ChainSettings } from "types";
 import { calculateUnbondingPeriod } from "./functions";
 import { fetchChainParameters, fetchRpcUrlFromIndexer } from "./services";
@@ -84,7 +81,3 @@ export const chainParametersAtom = atomWithQuery<ChainParameters>((get) => {
     },
   };
 });
-
-export const chainConfigAtom = atomFamily((chainName: string) =>
-  atom<ChainConfig>(() => chainConfigByName(chainName))
-);

apps/namadillo/src/registry/index.ts

@@ -3,6 +3,8 @@ import namada from "./namada.json";
 
 type MinimalDenom = string;
 type ConfigName = string;
+type ChainName = "cosmoshub" | "namada";
+type ChainMinDenom = "uatom" | "namnam";
 
 type Currency = {
   coinDecimals: number;
@@ -20,15 +22,20 @@ const loadedConfigs: ChainConfig[] = [];
 const minimalDenomMap: Map<string, number> = new Map();
 const nameMap: Map<string, number> = new Map();
 
-export function chainConfigByMinDenom(minDenom: string): ChainConfig {
-  // We assume that the map always has the key
-  const index = minimalDenomMap.get(minDenom)!;
+export function chainConfigByMinDenom(minDenom: ChainMinDenom): ChainConfig {
+  const index = minimalDenomMap.get(minDenom);
+  if (!index) {
+    throw new Error("Chain config not found");
+  }
+
   return loadedConfigs[index];
 }
 
-export function chainConfigByName(name: string): ChainConfig {
-  // We assume that the map always has the key
-  const index = nameMap.get(name)!;
+export function chainConfigByName(name: ChainName): ChainConfig {
+  const index = nameMap.get(name);
+  if (!index) {
+    throw new Error("Chain config not found");
+  }
   return loadedConfigs[index];
 }