This repository has been archived by the owner on Nov 14, 2018. It is now read-only.
SpannableStringBuilder extensions #436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Mar 14, 2018
| * | ||
| * @see SpannableStringBuilder.inSpans | ||
| */ | ||
| inline fun SpannableStringBuilder.down(builderAction: SpannableStringBuilder.() -> Unit) = |
There was a problem hiding this comment.
I don't think "up" and "down" correctly convey the behavior. "superscript" and "subscript" seem fine.
Also are these common enough that they warrant inclusion? I can't remember using them once.
| * | ||
| * @see SpannableStringBuilder.inSpans | ||
| */ | ||
| inline fun SpannableStringBuilder.font( |
There was a problem hiding this comment.
I'm torn between calling this "font" or "typeface" to match the span name. I suspect matching the span name will improve discoverability.
There was a problem hiding this comment.
Matching name seems like better, I renamed the methods - "up", "down", "font" to "superscript", "subscript" and "typeface" .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add wrappers for SuperscriptSpan, SubscriptSpan, TypefaceSpan and URLSpan