Adding alert to Change Existing User Account form #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR includes changed from your other one, which need to be removed. The change itself looks good to me. |
Thank you, you're right. A bit puzzled how it happened, as I have checked out to a new branch for this change from an up-to-date main, it's just the earlier PR those commits belong to is still live. I'll look into it. Edit: Should be OK now. |
PeterHattyar
force-pushed
the
adding-alert-to-change-user-account-form
branch
2 times, most recently
from
10817de
to
9c8215a
Compare
nicholsj
reviewed
Sep 5, 2024
app/views/change_existing_user_requests/_request_details.html.erb
Outdated
Show resolved
Hide resolved
nicholsj
reviewed
Sep 5, 2024
app/views/change_existing_user_requests/_request_details.html.erb
Outdated
Show resolved
Hide resolved
Adding an alert, advising users trying to use this form of circumstances when they do not need to raise a request.
PeterHattyar
force-pushed
the
adding-alert-to-change-user-account-form
branch
from
9c8215a
to
b61b404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an alert to the form, advising users trying to use this form
of circumstances when they do not need to raise a request.
As per Zendesk ticket: https://govuk.zendesk.com/agent/tickets/5908958
Closes #1463
Follow these steps if you are doing a Rails upgrade.