Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from libsass -> dart-sass #1253

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Commits on Jan 22, 2024

  1. Move from libsass -> dart-sass

    I followed these instructions [1].
    
    I'm hoping that this will fix a `SassC::SyntaxError` that I'm seeing
    after adding `govuk_publishing_components` when running
    `RAILS_ENV=production rails assets:precompile`.
    
    Note that running `bundle install` has removed the `ruby` platform. We
    think this is because `sass-embedded`, a dependency of `dartsass-rails`,
    doesn't have a non-platform-specific variant of the gem and so bundler
    can no longer support the `ruby` platform.
    
    [1]: https://docs.publishing.service.gov.uk/manual/migrate-to-dart-sass-from-libsass.html
    floehopper committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    610e25a View commit details
    Browse the repository at this point in the history