Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve email check regex #1202

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Improve email check regex #1202

merged 1 commit into from
Oct 13, 2023

Conversation

MuriloDalRi
Copy link
Contributor

AgaDufrat
AgaDufrat reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@AgaDufrat AgaDufrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some test (at lease for the example in the Sentry error)?

@MuriloDalRi
Copy link
Contributor Author

Can we add some test (at lease for the example in the Sentry error)?

Done

@AgaDufrat AgaDufrat self-requested a review October 13, 2023 15:49
@MuriloDalRi
Improve email check regex
9c33e53 
Use a more robust regexp to check emails
@MuriloDalRi MuriloDalRi merged commit a457520 into main Oct 13, 2023
6 checks passed
@MuriloDalRi MuriloDalRi deleted the email-regex branch October 13, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgaDufrat AgaDufrat Awaiting requested review from AgaDufrat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MuriloDalRi @AgaDufrat