Skip to content

Commit

Permalink
Fix failing test in content_change_requests_spec
Browse files Browse the repository at this point in the history
This has been failing since 1st Jan 2024.

We use the value of `next_year` (currently 2025) when setting
`needed_by_date` and `not_before_date` in the call to
`user_makes_a_content_change_request`. We were already using `next_year`
in our assertions against these date fields in the ticket comment but
our assertions against the same dates appearing in the custom_fields
were hardcoded to 2024.
  • Loading branch information
chrisroos committed Jan 10, 2024
1 parent 7df3c65 commit 40ae43b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions spec/features/content_change_requests_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
"custom_fields" =>
[{ "id" => 7_948_652_819_356, "value" => "cr_inaccuracy" },
{ "id" => 7_949_106_580_380, "value" => "cr_benefits" },
{ "id" => 7_949_136_091_548, "value" => "2024-12-31" },
{ "id" => 7_949_152_975_772, "value" => "2024-12-01" },
{ "id" => 7_949_136_091_548, "value" => "#{next_year}-12-31" },
{ "id" => 7_949_152_975_772, "value" => "#{next_year}-12-01" },
{ "id" => 8_250_061_570_844, "value" => "13:00" },
{ "id" => 8_250_075_489_052, "value" => "18:00" }],
"ticket_form_id" => 7_949_329_694_108,
Expand Down

0 comments on commit 40ae43b

Please sign in to comment.