Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove emergency alerts code #3976

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove emergency alerts code #3976

wants to merge 5 commits into from

Commits on Oct 1, 2024

  1. migration to delete broadcast data 

    this is a data migration (so no downgrade) that deletes broadcast
services and all associated data - this includes obvious things like
broadcast events and templates, but also everything connected to those
services like user permissions, inbound senders, ft_billing rows, etc

Although some of these theoretically shouldn't exist for broadcast
services (eg returned_letters), issue the deletes out of an abundance of
caution. These migrations need to pass on preview and staging as well as
production, and for example there was a broadcast service on staging
with an inbound sms number

This has been tested against a copy of the staging database.
    @leohemsted
    leohemsted committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0245e94 View commit details
    Browse the repository at this point in the history

  2. dont delete service-specific things if theres no services

    @leohemsted
    leohemsted committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4db6195 View commit details
    Browse the repository at this point in the history

  3. remove emergency alerts code 

    no longer used. there might be additional cleanup we can do of other
utils functions that dont have "alert" or "broadcast" in the name that
are no longer used
    @leohemsted
    leohemsted committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0dc8088 View commit details
    Browse the repository at this point in the history

  4. make TemplateSchemaNoDetail tidier now that it doesn't have content 

    the schema was originally created so that it could not show content.
However, then it needed content conditionally for broadcast messages so
content was added back in.

Now that broadcasts no longer exist we can revert that - however, for a
template that has a specific list of expected keys, it's nicer to just
list those rather than maintain a huge list of exceptions that needs to
be modified every time a field changes on the template model
    @leohemsted
    leohemsted committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1034637 View commit details
    Browse the repository at this point in the history

  5. fix flaky test

    @leohemsted
    leohemsted committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    dd6210a View commit details
    Browse the repository at this point in the history