Move guidance pages side nav out of main content #5237
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also stops content-template.html swapping the withoutnav_template.html layout for admin_template.html, so removing withoutnav_template.html from the inheritance chain. This was done, simply because it's odd to have a template with a side navigation use a layout called withoutnav_template.html. It also lets us remove the code for error summaries because, as far as I can see, no pages using content_template.html have forms. I inferred this by searching their view code for the error_summary_enabled flag.
kr8n3r
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Means using the skiplink will jump you straight to the main content area, as on other pages.
https://trello.com/c/wv0h4he6/966-side-navigation-isnt-bypassed-by-skiplink-on-guidance-pages?filter=label:Sept%202%202024%20accessibility%20audit
This also includes some tidying up of the
content_template.htmlcode. Details of which are in the commit.