Landing pages backend scaffold #4247
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Leena Gupte <leena.gupte@digital.cabinet-office.gov.uk>
- helper to convert hard-coded content details into tab component format
KludgeKML
force-pushed
the
landing-pages-backend-scaffold
branch
from
908f2d3
to
b77c4f0
Compare
- ignore theme for the moment
- namespace under Block - BlockFactory to simplify creation
- use theme to control classes on left and right side of blocks (TODO: this feels a bit presentational? Maybe move this to a helper/presenter and just return left and right column sizes and total column size? Perhaps since this is a Layout this is okay, though, since the purpose of this block is presentational?)
- Update factory to check that Block is in the ancestors rather than the direct ancestor - make two_column_layout derive from layout base
… the two-column layout Rename column_class_for_n_columns to column_class_for_equal_columns to be more coherent.
…from the content store first, _then_ fallback to fake if not found.
… blocks specified in the content item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How
Screenshots?