Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non breaking space and add text-wrap balance to homepage intro #4239

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Remove non breaking space and add text-wrap balance to homepage intro #4239

merged 1 commit into from
Sep 23, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Sep 20, 2024 •
edited
Loading

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What / Why

  • Remove non breaking space from homepage intro text
  • Add text-wrap: balance to achieve the same look visually without the non breaking space
  • This is because on mobile at certain font scales, the non breaking space causes a horizontal scrollbar as the text is not breaking onto a new line.
  • Trello card

Visual Changes

Before

Screenshot_20240920_140258_Firefox

After

Screenshot_20240920_140400_Firefox

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4239 September 20, 2024 12:54 Inactive
@AshGDS AshGDS self-assigned this Sep 20, 2024
@AshGDS AshGDS marked this pull request as ready for review September 20, 2024 13:18
@AshGDS AshGDS merged commit cbf87fe into main Sep 23, 2024
13 checks passed
@AshGDS AshGDS deleted the homepage-text-wrap-fix branch September 23, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinJJones MartinJJones MartinJJones approved these changes

Assignees

@AshGDS AshGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshGDS @MartinJJones @govuk-ci