Add redirect of support/new to /support #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baisa
force-pushed
the
redirect-support-new-page
branch
from
b728807
to
1952efe
Compare
ChrisBAshton
reviewed
Apr 8, 2024
config/routes.rb
Outdated
| @@ -39,7 +40,6 @@ | |||
|
|
|||
| get "search/", to: "search#search" | |||
|
|
|||
| resources :tickets, only: %i[new create] | |||
| get "tickets/confirmation", to: "tickets#confirmation" | |||
There was a problem hiding this comment.
I'd also remove this route - and add a redirect route for https://www.data.gov.uk/tickets/new -> https://www.data.gov.uk/support 🙏 thank you!
There was a problem hiding this comment.
Does this look all right?
There was a problem hiding this comment.
(Line 43 still needs deleting)
baisa
force-pushed
the
redirect-support-new-page
branch
from
1952efe
to
7d02aef
Compare
ChrisBAshton
reviewed
Apr 8, 2024
config/routes.rb
Outdated
| @@ -39,7 +40,8 @@ | |||
|
|
|||
| get "search/", to: "search#search" | |||
|
|
|||
| resources :tickets, only: %i[new create] | |||
| get "tickets/new", to: redirect("https://www.data.gov.uk/support") | |||
There was a problem hiding this comment.
Suggested change
| get "tickets/new", to: redirect("https://www.data.gov.uk/support") | |
| get "tickets/new", to: redirect("/support") |
I think that's correct 🙏
config/routes.rb
Outdated
| @@ -39,7 +40,6 @@ | |||
|
|
|||
| get "search/", to: "search#search" | |||
|
|
|||
| resources :tickets, only: %i[new create] | |||
| get "tickets/confirmation", to: "tickets#confirmation" | |||
There was a problem hiding this comment.
(Line 43 still needs deleting)
…eate To stop bots from being able to raise spam tickets.
baisa
force-pushed
the
redirect-support-new-page
branch
from
7d02aef
to
4c6a2c7
Compare
ChrisBAshton
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
LGTM 👍 please check the redirects work on integration before promoting to staging/production (as per https://docs.publishing.service.gov.uk/manual/data-gov-uk-deployment.html) - thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To stop bots from being able to raise spam tickets.
[Trello card] (https://trello.com/c/TrY9IEND/2300-dgu-form-spam)