Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use natspec smells #653

Merged
merged 22 commits into from
Sep 5, 2024
Merged

docs: use natspec smells #653

merged 22 commits into from
Sep 5, 2024

Conversation

ilpepepig
Copy link

No description provided.

@ilpepepig ilpepepig changed the base branch from v2.1 to refactor/repo August 28, 2024 15:12
Copy link

@0xAustrian 0xAustrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you also push the changes in bun.lockb?

contracts/core/Allo.sol Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ilpepepig ilpepepig changed the base branch from refactor/repo to v2.1 August 29, 2024 11:45
@0xOneTony 0xOneTony marked this pull request as ready for review August 29, 2024 14:33
Copy link

@0xOneTony 0xOneTony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a script in package.json that runs natspec-smells and add it as a step in the git workflow aswell? other than that looks good

@0xOneTony 0xOneTony merged commit 6e05f40 into v2.1 Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants